Skip to content

Fix compatibility with Symfony 4.3#2925

Merged
teohhanhui merged 1 commit into
api-platform:2.4from
teohhanhui:fix/symfony-messenger-4.3-compatibility
Jul 11, 2019
Merged

Fix compatibility with Symfony 4.3#2925
teohhanhui merged 1 commit into
api-platform:2.4from
teohhanhui:fix/symfony-messenger-4.3-compatibility

Conversation

@teohhanhui

@teohhanhui teohhanhui commented Jul 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2912, api-platform/api-platform#1169
License MIT
Doc PR N/A

#2784 fixed compatibility for Symfony 4.3 in master / 2.5. This is basically the same but without bumping the dependencies.

Together with #2920 (and maybe more to do in #2911) this should allow full Symfony 4.3 compatibility in 2.4.

This was referenced Jul 10, 2019
Closed
Closed
Merged
@teohhanhui

teohhanhui commented Jul 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Okay, this needs more work. 😆 Fixed.

@teohhanhui
teohhanhui force-pushed the fix/symfony-messenger-4.3-compatibility branch 2 times, most recently from b9a2a76 to 59ef4b4 Compare July 10, 2019 12:38
@teohhanhui teohhanhui changed the title Fix compatibility with Symfony Messenger 4.3 Fix compatibility with Symfony 4.3 Jul 10, 2019
@teohhanhui
teohhanhui force-pushed the fix/symfony-messenger-4.3-compatibility branch 6 times, most recently from e6436a9 to 23c99c0 Compare July 10, 2019 14:14
@teohhanhui
teohhanhui force-pushed the fix/symfony-messenger-4.3-compatibility branch from 23c99c0 to b694ef8 Compare July 10, 2019 14:16
@teohhanhui
teohhanhui requested review from alanpoulain and soyuka July 10, 2019 14:25
@teohhanhui

teohhanhui commented Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

We will need to be careful when merging this into master. Haha...

@dunglas

dunglas commented Jul 10, 2019

Copy link
Copy Markdown
Member

I'll let you do :p

@teohhanhui
teohhanhui merged commit 8d0bd66 into api-platform:2.4 Jul 11, 2019
@teohhanhui
teohhanhui deleted the fix/symfony-messenger-4.3-compatibility branch July 11, 2019 12:59
@karser

karser commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

Since symfony/messenger v4.3 introduces BC, is v4.2 still supported?

@teohhanhui

teohhanhui commented Jul 12, 2019

Copy link
Copy Markdown
Contributor Author

@karser Both are supported. As always, if we broke anything, please let us know.

@CorentinBoutillier

CorentinBoutillier commented Jul 19, 2019

Copy link
Copy Markdown

Hi, it seems to be related. During my composer req messenger (project based on api-pack), I get this error so I. can't install messenger component.

 Problem 1
    - Conclusion: don't install symfony/messenger v4.3.2
    - Conclusion: don't install symfony/messenger v4.3.1
    - symfony/messenger v4.3.0 conflicts with api-platform/core[v2.4.5].
    - symfony/messenger v4.3.0 conflicts with api-platform/core[v2.4.5].
    - symfony/messenger v4.3.0 conflicts with api-platform/core[v2.4.5].
    - Installation request for symfony/messenger 4.3.* -> satisfiable by symfony/messenger[v4.3.0, v4.3.1, v4.3.2].
    - Installation request for api-platform/core (locked at v2.4.5) -> satisfiable by api-platform/core[v2.4.5].

@karser

karser commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

@teqno this PR is not released yet. api-platform v2.4.5 conflicts with symfony/messenger: >=4.3.

@fri0z

fri0z commented Jul 26, 2019

Copy link
Copy Markdown

Is there a workaround for installing symfony/messenger ?

@soyuka

soyuka commented Jul 26, 2019

Copy link
Copy Markdown
Member

Force core to use our 2.4 branch directly? Or else you could stay with <4.3 everywhere and it should work!

@fri0z

fri0z commented Jul 26, 2019

Copy link
Copy Markdown

If I understand correctly the fix in the 2.4 branch no. https://github.com/api-platform/core/blob/2.4/composer.json#L76

@teohhanhui

teohhanhui commented Jul 29, 2019

Copy link
Copy Markdown
Contributor Author

@fri0z Use "api-platform/core": "2.4.x-dev" in your composer.json

@fri0z

fri0z commented Jul 29, 2019

Copy link
Copy Markdown

@teohhanhui Thanks, but i solved, downgrading symfony to 4.2

@Alexandre-T

Alexandre-T commented Aug 19, 2019

Copy link
Copy Markdown

@teohhanhui Thanks!
I removed "api-platform/api-pack" from my composer.json then I add "api-platform/core": "2.4.x-dev" and there is no more conflict.
I manually add the packages which have been removed because of api-pack:

        "phpdocumentor/reflection-common": "^1.0.1",
        "phpdocumentor/reflection-docblock": "^4.3.1",
        "phpdocumentor/type-resolver": "^0.4.0",
        "symfony/asset": "^4.3",
        "symfony/expression-language": "^4.3",
        "symfony/validator": "^4.3",
        "webmozart/assert": "^1.4.0"

Thanks for your help and this awesome api-platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes
@alanpoulain alanpoulain alanpoulain approved these changes
@meyerbaptiste meyerbaptiste Awaiting requested review from meyerbaptiste
@soyuka soyuka Awaiting requested review from soyuka

Assignees

No one assigned

Labels

[RFR] Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@teohhanhui @dunglas @karser @CorentinBoutillier @fri0z @soyuka @Alexandre-T @alanpoulain